Skip to content

conn pool: fixing overly aggressive connect #19780

Merged
alyssawilk merged 3 commits intoenvoyproxy:mainfrom
alyssawilk:no_new_while_draining
Feb 3, 2022
Merged

conn pool: fixing overly aggressive connect #19780
alyssawilk merged 3 commits intoenvoyproxy:mainfrom
alyssawilk:no_new_while_draining

Conversation

@alyssawilk
Copy link
Copy Markdown
Contributor

Fixing a bug where the connection pool attempts to establish new connections while draining.

Risk Level: low
Testing: integration test
Docs Changes: n/a
Release Notes: n/a

Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
@alyssawilk
Copy link
Copy Markdown
Contributor Author

/retest

@repokitteh-read-only
Copy link
Copy Markdown

Retrying Azure Pipelines:
Retried failed jobs in: envoy-presubmit

🐱

Caused by: a #19780 (comment) was created by @alyssawilk.

see: more, trace.

Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
@alyssawilk alyssawilk merged commit 0682963 into envoyproxy:main Feb 3, 2022
joshperry pushed a commit to joshperry/envoy that referenced this pull request Feb 13, 2022
Fixing a bug where the connection pool attempts to establish new connections while draining.

Risk Level: low
Testing: integration test
Docs Changes: n/a
Release Notes: n/a
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
Signed-off-by: Josh Perry <josh.perry@mx.com>
@alyssawilk alyssawilk deleted the no_new_while_draining branch August 4, 2022 00:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants